"""Tests for gateway code-skew detection (stale-checkout guard). Companion to ``tests/test_stale_utils_module_import.py``: that test proves the crash; these prove the guard that turns it into a clear "restart the gateway" message before a model switch can hit it. The dashboard mirror (#86207) lives here too: ``web_server_config._dashboard_code_skew_guard`` and the ``/api/model/options`` 503 guard, which protect the Models page from the same stale-module ImportError after ``hermes update``. """ import asyncio import contextlib import pytest from gateway import code_skew import hermes_cli.web_routers.models as _rt_models import hermes_cli.web_server_config as _web_server_config import hermes_cli.web_server_profiles as _web_server_profiles @pytest.fixture(autouse=True) def _reset_boot_fingerprint(monkeypatch): """Each test starts with no recorded boot fingerprint.""" monkeypatch.setattr(code_skew, "_boot_fingerprint", None) class TestDetectCodeSkew: def test_no_boot_fingerprint_means_no_skew(self, monkeypatch): # Nothing recorded (e.g. non-git install) -> never a false positive. monkeypatch.setattr(code_skew, "_fingerprint", lambda: "git:refs/heads/main:def456") assert code_skew.detect_code_skew() is None def test_drift_is_detected_with_short_revs(self, monkeypatch): monkeypatch.setattr(code_skew, "_fingerprint", lambda: "git:refs/heads/main:abc1234567890") code_skew.record_boot_fingerprint() monkeypatch.setattr(code_skew, "_fingerprint", lambda: "git:refs/heads/main:def4567890123") skew = code_skew.detect_code_skew() assert skew == ("abc1234567", "def4567890") class TestShort: def test_keeps_unresolved_marker(self): assert code_skew._short("git:refs/heads/main:unresolved") == "unresolved" class TestModelSwitchSkewGuard: def test_guard_message_names_revs_and_restart(self, monkeypatch): from gateway import slash_commands_model as slash_commands monkeypatch.setattr(code_skew, "detect_code_skew", lambda: ("abc1234567", "def4567890")) msg = slash_commands._model_switch_skew_guard() assert msg is not None assert "abc1234567" in msg assert "def4567890" in msg assert "hermes gateway restart" in msg class TestDashboardCodeSkewGuard: """Dashboard mirror of the gateway's model-switch skew guard (#86207).""" def test_dashboard_guard_message_names_revs_and_restart(self, monkeypatch): monkeypatch.delenv("HERMES_SERVE_HEADLESS", raising=False) monkeypatch.setattr(code_skew, "detect_code_skew", lambda: ("abc1234567", "def4567890")) msg = _web_server_config._dashboard_code_skew_guard() assert msg is not None assert "abc1234567" in msg assert "def4567890" in msg assert "restart" in msg.lower() # Browser-dashboard path: never hardcode a Linux-only unit (#97046). assert "systemctl" not in msg def test_serve_guard_message_points_at_desktop_backend(self, monkeypatch): monkeypatch.setenv("HERMES_SERVE_HEADLESS", "1") monkeypatch.setattr(code_skew, "detect_code_skew", lambda: ("abc1234567", "def4567890")) msg = _web_server_config._dashboard_code_skew_guard() assert msg is not None assert "Desktop-owned backend" in msg assert "systemctl" not in msg assert "hermes-dashboard" not in msg class TestModelOptionsSkewGuard: """/api/model/options must refuse with a clear 503 when the dashboard is stale. Regression for #86207: a dashboard kept alive across ``hermes update`` serves stale modules, so the picker's lazy import of names the update added (``agent.model_metadata.is_grok_46_family``) raised ImportError and the handler collapsed it into a generic 500. With the guard, the stale process surfaces "Restart required" (503) and never reaches the payload build. """ def test_stale_dashboard_returns_503_and_skips_payload_build(self, monkeypatch): from fastapi import HTTPException monkeypatch.setattr(code_skew, "detect_code_skew", lambda: ("abc1234567", "def4567890")) payload_calls: list = [] monkeypatch.setattr( "hermes_cli.inventory.build_model_options_payload", lambda *a, **k: payload_calls.append(1) or {"providers": []}, ) with pytest.raises(HTTPException) as excinfo: asyncio.run(_rt_models.get_model_options()) assert excinfo.value.status_code == 503 assert "restart" in str(excinfo.value.detail).lower() # The stale-import crash site (the payload build) is never reached. assert payload_calls == [] def test_fresh_dashboard_builds_payload_unchanged(self, monkeypatch): monkeypatch.setattr(code_skew, "detect_code_skew", lambda: None) async def _fake_run_in_threadpool(func): return func() monkeypatch.setattr(_rt_models, "run_in_threadpool", _fake_run_in_threadpool) monkeypatch.setattr( _web_server_profiles, "_profile_scope", lambda profile: contextlib.nullcontext() ) monkeypatch.setattr("hermes_cli.inventory.load_picker_context", lambda: {}) payload_calls: list = [] expected = {"providers": [], "model": {}, "provider": None} monkeypatch.setattr( "hermes_cli.inventory.build_model_options_payload", lambda *a, **k: payload_calls.append(1) or expected, ) result = asyncio.run(_rt_models.get_model_options()) assert result == expected assert payload_calls == [1] class TestModelSetSkewGuard: """#99859 (R2): POST /api/model/set is the WRITE twin of the guarded picker — a stale process persisting a post-update model string serves an invalid model after the restart it itself needs. It must refuse with the same 503 and never reach the assignment apply.""" def test_stale_model_set_returns_503_and_skips_assignment(self, monkeypatch): from fastapi import HTTPException monkeypatch.setattr(code_skew, "detect_code_skew", lambda: ("abc1234567", "def4567890")) applied: list = [] monkeypatch.setattr(_rt_models, "_apply_model_assignment_sync", lambda *a, **k: applied.append(1)) body = _rt_models.ModelAssignment(scope="main", provider="nous", model="some-model") with pytest.raises(HTTPException) as excinfo: asyncio.run(_rt_models.set_model_assignment(body)) assert excinfo.value.status_code == 503 assert "restart" in str(excinfo.value.detail).lower() assert applied == [] def test_fresh_model_set_proceeds(self, monkeypatch): monkeypatch.setattr(code_skew, "detect_code_skew", lambda: None) async def _to_thread(fn): return fn() monkeypatch.setattr(_rt_models.asyncio, "to_thread", _to_thread) monkeypatch.setattr(_web_server_profiles, "_profile_scope", lambda profile: contextlib.nullcontext()) monkeypatch.setattr(_rt_models, "_prepare_main_assignment", lambda cfg, *a: {"ok": True}) monkeypatch.setattr(_rt_models, "_apply_model_assignment_sync", lambda *a, **k: {"ok": True, "scope": "main"}) body = _rt_models.ModelAssignment(scope="main", provider="nous", model="some-model") result = asyncio.run(_rt_models.set_model_assignment(body)) assert result["ok"] is True